Release version 5.0.0+hotfix.4

permission_handler/CHANGELOG.md

+## 5.0.0+hotfix.4
+
+* Solve issue on Android causing an IllegalStateException ([#267](https://github.com/Baseflow/flutter-permission-handler/issues/267))
+
 ## 5.0.0+hotfix.3
 
 * Includes the changes of 4.4.0+hotfix.4 (which was released to be backwardscompatible).

permission_handler/README.md

@@ -9,30 +9,33 @@ On Android, you can show a rationale for requesting a permission.
 
 ## Setup
 
-While the permissions are being requested during runtime, you'll still need to tell the OS which permissions your app might potentially use.  
-That requires adding permission configuration to Android- and iOS-specific files.
+While the permissions are being requested during runtime, you'll still need to tell the OS which permissions your app might potentially use. That requires adding permission configuration to Android- and iOS-specific files.
 
 <details>
 <summary>Android</summary>
+  
+**Upgrade pre 1.12 Android projects**
+  
+Since version 4.4.0 this plugin is implemented using the Flutter 1.12 Android plugin APIs. Unfortunately this means App developers also need to migrate their Apps to support the new Android infrastructure. You can do so by following the [Upgrading pre 1.12 Android projects](https://github.com/flutter/flutter/wiki/Upgrading-pre-1.12-Android-projects) migration guide. Failing to do so might result in unexpected behaviour. Most common known error is the permission_handler not returning after calling the `.request()` method on a permission. 
+
+**AndroidX**
 
-> The current version of the plugin requires AndroidX.
->
-> As of version 3.1.0 the <kbd>permission_handler</kbd> plugin switched to the AndroidX version of the Android Support Libraries. This means you need to make sure your Android project is also upgraded to support AndroidX. Detailed instructions can be found [here](https://flutter.dev/docs/development/packages-and-plugins/androidx-compatibility).
->
-> The TL;DR version is:
-> 1. Add the following to your "gradle.properties" file:
-> ```
-> android.useAndroidX=true
-> android.enableJetifier=true
-> ```
-> 2. Make sure you set the `compileSdkVersion` in your "android/app/build.gradle" file to 28:
-> ```
-> android {
-  >   compileSdkVersion 28
->   ...
-> }
-> ```
-> 3. Make sure you replace all the `android.` dependencies to their AndroidX counterparts (a full list can be found here: https://developer.android.com/jetpack/androidx/migrate).
+As of version 3.1.0 the <kbd>permission_handler</kbd> plugin switched to the AndroidX version of the Android Support Libraries. This means you need to make sure your Android project is also upgraded to support AndroidX. Detailed instructions can be found [here](https://flutter.dev/docs/development/packages-and-plugins/androidx-compatibility).
+
+The TL;DR version is:
+1. Add the following to your "gradle.properties" file:
+```
+android.useAndroidX=true
+android.enableJetifier=true
+```
+2. Make sure you set the `compileSdkVersion` in your "android/app/build.gradle" file to 28:
+```
+android {
+  compileSdkVersion 28
+  ...
+}
+```
+3. Make sure you replace all the `android.` dependencies to their AndroidX counterparts (a full list can be found here: https://developer.android.com/jetpack/androidx/migrate).
 
 Add permissions to your `AndroidManifest.xml` file.
 There's a `debug`, `main` and `profile` version which are chosen depending on how you start your app.
@@ -105,7 +108,12 @@ You can remove permissions you don't use:
      end
    end
    ```
-2. Delete the corresponding permission description in `Info.plist`
+2. Remove the `#` character in front of the permission you do not want to use. For example if you don't need access to the calendar make sure the code looks like this:
+   ```ruby
+           ## dart: PermissionGroup.calendar
+           'PERMISSION_EVENTS=0',
+   ```
+3. Delete the corresponding permission description in `Info.plist`
    e.g. when you don't need camera permission, just delete 'NSCameraUsageDescription'
    The following lists the relationship between `Permission` and `The key of Info.plist`:
    | Permission                                                                                  | Info.plist                                                                                                    | Macro                        |
@@ -121,7 +129,7 @@ You can remove permissions you don't use:
    | PermissionGroup.notification                                                                | PermissionGroupNotification                                                                                   | PERMISSION_NOTIFICATIONS     |
    | PermissionGroup.mediaLibrary                                                                | NSAppleMusicUsageDescription, kTCCServiceMediaLibrary                                                         | PERMISSION_MEDIA_LIBRARY     |
    | PermissionGroup.sensors                                                                     | NSMotionUsageDescription                                                                                      | PERMISSION_SENSORS           |
-3. Clean & Rebuild
+4. Clean & Rebuild
 
 </details>
 

permission_handler/android/src/main/java/com/baseflow/permissionhandler/ServiceManager.java

@@ -36,11 +36,12 @@ final class ServiceManager {
         if (permission == PermissionConstants.PERMISSION_GROUP_LOCATION ||
             permission == PermissionConstants.PERMISSION_GROUP_LOCATION_ALWAYS ||
             permission == PermissionConstants.PERMISSION_GROUP_LOCATION_WHEN_IN_USE) {
-                final int serviceStatus = isLocationServiceEnabled(context)
-                        ? PermissionConstants.SERVICE_STATUS_ENABLED
-                        : PermissionConstants.SERVICE_STATUS_DISABLED;
+            final int serviceStatus = isLocationServiceEnabled(context)
+                    ? PermissionConstants.SERVICE_STATUS_ENABLED
+                    : PermissionConstants.SERVICE_STATUS_DISABLED;
 
-                successCallback.onSuccess(serviceStatus);
+            successCallback.onSuccess(serviceStatus);
+            return;
         }
 
         if (permission == PermissionConstants.PERMISSION_GROUP_PHONE) {

permission_handler/ios/permission_handler.podspec

@@ -3,7 +3,7 @@
 #
 Pod::Spec.new do |s|
   s.name             = 'permission_handler'
-  s.version          = '5.0.0+hotfix.3'
+  s.version          = '5.0.0+hotfix.4'
   s.summary          = 'Permission plugin for Flutter.'
   s.description      = <<-DESC
 Permission plugin for Flutter. This plugin provides a cross-platform (iOS, Android) API to request and check permissions.

permission_handler/pubspec.yaml

 name: permission_handler
 description: Permission plugin for Flutter. This plugin provides a cross-platform (iOS, Android) API to request and check permissions.
-version: 5.0.0+hotfix.3
+version: 5.0.0+hotfix.4
 homepage: https://github.com/baseflowit/flutter-permission-handler
 
 flutter: