Moves Java compile arguments (#1112)

* Moves Java compile arguments

* Fix fallthrough warnings

permission_handler_android/CHANGELOG.md

+## 10.3.3
+
+* Migrates the Gradle compile arguments to the example app, so they are not enforced upon consumers of the plugin.
+
 ## 10.3.2
 
 * Updates example app to show `Permission.photos` and hide `Permission.bluetooth`.

permission_handler_android/android/build.gradle

 group 'com.baseflow.permissionhandler'
 version '1.0'
-def args = ["-Xlint:deprecation","-Xlint:unchecked","-Werror"]
 
 buildscript {
     repositories {
@@ -20,10 +19,6 @@ rootProject.allprojects {
     }
 }
 
-project.getTasks().withType(JavaCompile){
-    options.compilerArgs.addAll(args)
-}
-
 apply plugin: 'com.android.library'
 
 android {

permission_handler_android/android/src/main/java/com/baseflow/permissionhandler/PermissionUtils.java

@@ -122,25 +122,24 @@ public class PermissionUtils {
                 break;
 
             case PermissionConstants.PERMISSION_GROUP_LOCATION_ALWAYS:
+            case PermissionConstants.PERMISSION_GROUP_LOCATION_WHEN_IN_USE:
+            case PermissionConstants.PERMISSION_GROUP_LOCATION:
                 // Note that the LOCATION_ALWAYS will deliberately fallthrough to the LOCATION
                 // case on pre Android Q devices. The ACCESS_BACKGROUND_LOCATION permission was only
                 // introduced in Android Q, before it should be treated as the ACCESS_COARSE_LOCATION or
                 // ACCESS_FINE_LOCATION.
-                if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) {
+                if (permission == PermissionConstants.PERMISSION_GROUP_LOCATION_ALWAYS && Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) {
                     if (hasPermissionInManifest(context, permissionNames, Manifest.permission.ACCESS_BACKGROUND_LOCATION))
                         permissionNames.add(Manifest.permission.ACCESS_BACKGROUND_LOCATION);
                     break;
                 }
-            case PermissionConstants.PERMISSION_GROUP_LOCATION_WHEN_IN_USE:
-            case PermissionConstants.PERMISSION_GROUP_LOCATION:
+
                 if (hasPermissionInManifest(context, permissionNames, Manifest.permission.ACCESS_COARSE_LOCATION))
                     permissionNames.add(Manifest.permission.ACCESS_COARSE_LOCATION);
 
                 if (hasPermissionInManifest(context, permissionNames, Manifest.permission.ACCESS_FINE_LOCATION))
                     permissionNames.add(Manifest.permission.ACCESS_FINE_LOCATION);
                 break;
-
-
             case PermissionConstants.PERMISSION_GROUP_SPEECH:
             case PermissionConstants.PERMISSION_GROUP_MICROPHONE:
                 if (hasPermissionInManifest(context, permissionNames, Manifest.permission.RECORD_AUDIO))
@@ -191,7 +190,7 @@ public class PermissionUtils {
                         permissionNames.add(Manifest.permission.BODY_SENSORS_BACKGROUND);
                     }
                 }
-
+                break;
             case PermissionConstants.PERMISSION_GROUP_SMS:
                 if (hasPermissionInManifest(context, permissionNames, Manifest.permission.SEND_SMS))
                     permissionNames.add(Manifest.permission.SEND_SMS);

permission_handler_android/example/android/build.gradle

@@ -25,3 +25,15 @@ subprojects {
 tasks.register("clean", Delete) {
     delete rootProject.buildDir
 }
+
+// Build the plugin project with warnings enabled. This is here rather than
+// in the plugin itself to avoid breaking clients that have different
+// warnings (e.g., deprecation warnings from a newer SDK than this project
+// builds with).
+gradle.projectsEvaluated {
+    project(":permission_handler_android") {
+        tasks.withType(JavaCompile) {
+            options.compilerArgs << "-Xlint:all" << "-Werror"
+        }
+    }
+}

permission_handler_android/pubspec.yaml

 name: permission_handler_android
 description: Permission plugin for Flutter. This plugin provides the Android API to request and check permissions.
 homepage: https://github.com/baseflow/flutter-permission-handler
-version: 10.3.2
+version: 10.3.3
 
 environment:
   sdk: ">=2.15.0 <4.0.0"